search

mit-dci / lit

Lightning Network node software
MIT License
551 stars 119 forks source link

Make integration tests for DLCs #319

Open gertjaap opened 6 years ago

gertjaap commented 6 years ago

See #318

delbonis commented 6 years ago

The issue in #318 is actually a bug in lit-af. Perhaps we should write tests for lit-af as well.

Varunram commented 6 years ago

I notice #318 was due to https://github.com/mit-dci/lit/pull/279. As I pointed out in another PR, lets be careful with merges and not merge stuff that is explicitly marked Ready to Merge. Ready to Merge is when someone who is familiar / has handled that part of the code reviews the PR and ensures it performs as per expectations (more emphasis on the latter part). As for the PR at hand, the status on the tracker said "Waiting for review" but the PR was slated for merge (my review asked for @gertjaap's review on the DLC part).

infografx commented 5 years ago

Hello. If nobody works on it. I'm going to do. You could mark this #319 as 'in progress'.

infografx commented 5 years ago

Hello. I have written a tests for the DLC subsystem up to setup the r-point. But for this I had to modify the dlcoracle itself. It was not intended to run the in automatic way.

I have added some command line parameters to the dlcoracle: DataDir - so It could save keys in a test folder HttpPort - to create multiple instances Interval - to control the data publishing interval. To set the appropriate time when creating a r-point.

So before this pull request I need to issue a pull request for the dlcoracle.

wip.

infografx commented 5 years ago

Hello.

https://github.com/mit-dci/dlcoracle/pull/5 https://github.com/mit-dci/lit/pull/451