search

mit-dci / lit

Lightning Network node software
MIT License
551 stars 119 forks source link

Restructure the way stuff is handled in lnp2p #403

Open Varunram opened 6 years ago

Varunram commented 6 years ago

Contains name changes, call by value / reference changes, removes unnecessary handler functions and more.

Varunram commented 6 years ago

test fails due to jenkins being down, unrelated to the PR itself.

delbonis commented 6 years ago

Don't mean to frustrate you with all the comments, I just made lnp2p very opinionated because I wanted to make it easier to refactor around.

Varunram commented 6 years ago

Yeah sure, the reason why we have reviews is to debate upon such points. I think we didn't review / discuss upon the refactor PR much before merging, so it makes sense to review them here.

adiabat commented 6 years ago

There are several large binary files in this PR, can you remove them (and maybe rebuild the git commit log to never have them so they're not included in the history)

Varunram commented 6 years ago

should be good now