mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

Extend test script #123

Closed mszulcz-mitre closed 2 years ago

mszulcz-mitre commented 2 years ago

This pull request addresses Issue 122, 'Extend test.sh'. test.sh is the script that runs unit tests and integration tests and measures coverage. This pull request contains commits that extend it in the following ways:

In addition, test.sh now adheres to the 80-char. line limit followed in the repo's C++ code. It also now has variable references enclosed in double quotes, as recommended in the Advanced Bash Scripting Guide.

The new test.sh in this pull request is completely backward compatible: running it with no command-line arguments does exactly what the previous version of the script does. As a result, documentation that references the script and code that invokes it should not need to change. Also, users don't need to change how they use the script if they don't want to.

HalosGhost commented 2 years ago

Rather than opening multiple pull-requests and closing them, it probably makes more sense to open one and force-push to override changes. Feel free to use Draft PRs as well if something isn't quite ready for review! :)

mszulcz-mitre commented 2 years ago

Sorry about that! I'll open a new draft PR. I probably should've done that from the start.

If there's any way to delete these closed PRs, they're probably not useful to keep.

HalosGhost commented 2 years ago

Don't worry about it (just reduces a bit of noise for me). And Github actually doesn't support deleting PRs (requires specifically asking support to do so), but they're not doing any harm.