search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

Enable `readability-identifier-length` lint check? #165

Open HalosGhost opened 2 years ago

HalosGhost commented 2 years ago

As mentioned in #162, much of the codebase is not compliant with this newly-added clang-tidy check. Looks like the default settings (which we mostly tend to keep) requires that variables names be 3 characters long or longer.

This is as much a question on whether or not we should enable such a stringent check as it is a question of what settings we should enforce.

HalosGhost commented 2 years ago

cc @metalicjames

SumantxD commented 1 year ago

@HalosGhost could you assign me this issue, i would like to work on it

HalosGhost commented 1 year ago

Before you start working on making the code compliant with the check, do you have any thoughts on whether or not the default length is appropriate, or do you think it makes sense to just fit with the default?