search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

Reduce failures to connect from fatal errors to warnings #169

Closed metalicjames closed 2 years ago

metalicjames commented 2 years ago

Follow up from #168. This PR reduces all failures to connect from fatal errors to warnings. This should eliminate the startup order requirement of the system components.

I think I got them all, but it's possible I missed one.

wadagso-gertjaap commented 2 years ago

Without this the 2PC system cannot start up regardless of the order:

The 2PC sentinel creates separate network clients for each of the other sentinels (for the attestation feature) - meaning if connecting to it fails, the sentinel fails to start up.

Combined with the fact that the sentinel doesn't start listening before it has connected to other sentinels means the system can't ever start up.

kylecrawshaw commented 2 years ago

Thanks for changing this @metalicjames . This fixes the issues I observed in https://github.com/mit-dci/opencbdc-tx/issues/167