Closed pr4u4t closed 1 year ago
Mmm, that is indeed not ideal. In particular, on any platform where leveldb
is being built-from-source (cf. #162, will be all platforms soon), we need to ensure we're handling the dependencies correctly.
To that end, your branch looks good, but should also probably include snappy
as a package to install in ./scripts/configure.sh
.
cc @metalicjames; do you think we should pull in these changes as a part of #162?
Mmm, that is indeed not ideal. In particular, on any platform where
leveldb
is being built-from-source (cf. #162, will be all platforms soon), we need to ensure we're handling the dependencies correctly.To that end, your branch looks good, but should also probably include
snappy
as a package to install in./scripts/configure.sh
.
Added snappy to apt-get/homebrew,opening pull request.
Affected Branch
trunk
Basic Diagnostics
[X] I've pulled the latest changes on the affected branch and the issue is still present.
[ ] The issue is reproducible in docker
Description
Only example of error message from build. Multiple unresolved symbols from snappy library when building on Arch Linux.
In order to reproduce the issue, follow these steps:
Well it looks like snappy should be added to CMakeList.txt in multiple files using check_library_exists() and target_link_libraries().
Proposed changes can be viewed arch-linux-snappy. Let me know if pull request is desired.
Code of Conduct