search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

Moved decode_address from client-cli to client #176

Closed pr4u4t closed 1 year ago

pr4u4t commented 2 years ago

Moved address_decode from client-cli to client since this function may be reused in other units later.

HalosGhost commented 2 years ago

since this function may be reused in other units later.

That's interesting. I have no reason to suggest otherwise, but do you have something in-mind?

pr4u4t commented 2 years ago

I'm making a REST interface based on client-cli and decode address is needed there and I don't want to duplicate this code.

HalosGhost commented 2 years ago

When you say that it's “based on client-cli,” you mean that your REST interface is shelling out and executing a command-line utility? I would wonder if it would make more sense long-term for us to move decode_address and other potentially-helpful methods out to util and create a shared library from the utilities so that there's a well-defined entry point for higher layers.

HalosGhost commented 1 year ago

All-in-all, this looks largely ready to merge, though there is still a lint error that should be resolved first.

HalosGhost commented 1 year ago

via #210