search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
895 stars 200 forks source link

Use explicit path to specify snappy library target #192

Closed AlexRamRam closed 1 year ago

AlexRamRam commented 1 year ago

By using the $SNAPPY_LIBRARY env var defined in the base CMakeLists.txt. Note that in macOS the brew snappy library installation path may not be in the LD_LIBRARY_PATH, hence this is required

Signed-off-by: Alexander Jung 104335080+AlexRamRam@users.noreply.github.com

HalosGhost commented 1 year ago

@metalicjames I've tested 2129fba46ad5b6ddca98a355de938423033dd1f2 in a clean environment, and everything went swimmingly. All else held equal, I'd prefer to have fewer dependencies than more. @AlexRamRam can you test James's commit above to confirm that it also solves a clean-build in macOS?

AlexRamRam commented 1 year ago

@metalicjames I've tested 2129fba in a clean environment, and everything went swimmingly. All else held equal, I'd prefer to have fewer dependencies than more. @AlexRamRam can you test James's commit above to confirm that it also solves a clean-build in macOS?

Yes - commit https://github.com/mit-dci/opencbdc-tx/commit/2129fba46ad5b6ddca98a355de938423033dd1f2 builds fine in MacOS (tested after removing snappy & leveldb).

HalosGhost commented 1 year ago

@AlexRamRam Thank you for testing. I'd actually like to close this then. @metalicjames would you like to open a PR with just 2129fba, and I can merge it ASAP?