Add default platform for Docker builds

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency

Other

898 stars 198 forks source link

Add default platform for Docker builds #248

Closed maurermi closed 8 months ago

maurermi commented 8 months ago

Addresses an issue seen with M-series Macs where Docker looks to pull images built for the linux/arm64/v8 platform instead of the linux/amd64 platform by default.

Specifies platform: linux/amd64 in docker-compose files to fix this issue for Mac users.

Minor additional change: also renames the image built / targeted by docker-compose-parsec-test.yml to opencbdc-tx-parsec instead of opencbdc-tx to match convention.

maurermi commented 8 months ago

Tested these changes on an M1 Mac and on my personal non-Mac system.

Would be great to get approval from another M-series Mac user and a non-Mac user if possible.

HalosGhost commented 8 months ago

utACK. Specifies amd64 as the platform for all docker images so that the right image is grabbed by-default across any platform.

Looks like we have a tACK from Hung Nguyen in the community. I don't have Apple Silicon to test on so I cannot give a tACK, but @maurermi if Hung's use serves as confirmation for you, I'm happy to approve and merge.

maurermi commented 8 months ago

@HalosGhost That sounds good to me!