search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

ci: get docker merge passing; fixes #283 #285

Closed rockett-m closed 1 month ago

rockett-m commented 1 month ago

Changed docker merge stage to run on pull-request in addition to merge to see if it will pass or fail before a merge takes place. .github/workflows/docker-push.yml Although it is for testing, it might be valuable to keep this to avoid future issues

Edited the.dockerignore and Dockerfile so that scripts/activate-venv.sh is found Error:

...
251.1 scripts/install-build-tools.sh: line 87: /scripts/activate-venv.sh: No such file or directory
-----------------------------------
Dockerfile:23
-----------------------------------
21 |      WORKDIR /opt/tx-processor
22 | 
23 |  >>> RUN scripts/install-build-tools.sh
24 |      RUN scripts/setup-dependencies.sh
----------------------------------
ERROR: failed to solve: process "/bin/sh -c scripts/install-build-tools.sh" did not complete successfully: exit code: 1
...

Added '.' to scripts/install-build-tools.sh sourcing the venv instead of 'source' due to Michael's point about sh not being able to run source.

rockett-m commented 1 month ago

@HalosGhost and/or @maurermi would you be able to review this? Thanks

rockett-m commented 1 month ago

Just ran and 8/8 checks passed. I had the docker merge stage included to see if it would pass.

I have now removed just the docker-merge on pull-request and re-pushed the commit. Should be good to go now