search

mit-dci / opencbdc-tx

A transaction processor for a hypothetical, general-purpose, central bank digital currency
Other
896 stars 198 forks source link

change default ports #289

Closed eolesinski closed 1 month ago

eolesinski commented 1 month ago

This PR addresses issue #97 by updating the port numbers used in the raft_test.cpp unit tests to a higher range (29800-29802) to avoid conflicts with commonly used ports.

Port conflicts with 5000 are frequent, especially with the docker-registry and Apple's AirPlay Receiver on MacOS. To address this issue, the default ports are updated to 298xx, following the convention outlined in #259.

Tested: tested by running ./scripts/test.sh

EDIT: This change now updates all test endpoints that use ports at 5xxx

HalosGhost commented 1 month ago

It looks like there are a ~lot of~few other tests which use 5xxx portnumbers; are you hoping to address those all in this PR as well?

In particular, the cfg files used by the integration test suites.

eolesinski commented 1 month ago

@HalosGhost Yep - I can go through the other tests and make those changes