search

mit-dci / opencx

An open-source cryptocurrency exchange toolkit for implementing experimental exchange features
MIT License
201 stars 63 forks source link

Make Assets conform to SLIP-0044 #15

Open Rjected opened 5 years ago

Rjected commented 5 years ago

Is your feature request related to a problem? Please describe. Currently the Asset struct assigns arbitrary, non-standard bytes to be used for asset identification by the server. It would be useful to include a standard that can be used for both BIP-0044 (as the HDCoinType) and the exchange (as an asset identifier). SLIP-0044 solves this problem, so it would make sense to implement this as the definition of the Asset struct.

Describe the solution you'd like Implement SLIP-0044 as the definition of the Asset struct and make sure all of the cointypes that come from lit repo use it, or are compatible with the rest of opencx.

Describe alternatives you've considered There do not seem to be many alternatives other than using the coin types in lit coinparams.

Additional context N/A

metalicjames commented 5 years ago

FYI the cointypes in the Lit params are supposed to be slip-0044 conforming.

Rjected commented 5 years ago

Good to know, that should make a lot of things pretty easy then