search

mit-dci / utreexo

accumulator for bitcoin utxo set
MIT License
323 stars 60 forks source link

github workflows: add coveralls for test coverage reports #321

Open sloorush opened 3 years ago

sloorush commented 3 years ago

what it does

Add goveralls that gives reports on test coverage of the project.

how it does

Currently covering package accumulator.

It gives reports like this(below) on https://coveralls.io/ image image

~## Need suggestion on Is there a better way to structure the workflows? Because right now, it runs the unit tests twice, which is not ideal or some way the job doesn't run out of memory.~

~edit: I found the issue of the Job getting cancelled, working on it~ edit: work done

sloorush commented 3 years ago

Ready for review!

@kcalvinalvin @adiabat Please take a look at it 😄

kcalvinalvin commented 3 years ago

Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those back in to minimize the lines of change?

sloorush commented 3 years ago

Most of the code is the same right? It's a bit hard to review since there's removed lines that turn this into a decently sized change. Could you add those back in to minimize the lines of change?

YAML formatter suggested moving the steps by one indent ahead, so they were indented automatically Shifted them back to the previous indent! 😄

kcalvinalvin commented 3 years ago

Tested. Looks good 👍

sloorush commented 2 years ago

@adiabat @kcalvinalvin, this PR can be merged. 😅

kcalvinalvin commented 2 years ago

@adiabat @kcalvinalvin, this PR can be merged. 😅

I don't have merge access to this repo. @adiabat?