search

mit-dci / utreexo

accumulator for bitcoin utxo set
MIT License
323 stars 60 forks source link

Separate out the unit tests from the integration tests #340

Open kcalvinalvin opened 2 years ago

kcalvinalvin commented 2 years ago

Right now the repository states that all tests are failing which is not true. All the unit tests in the accumulator library are passing, the integration tests in test/ are failing.

The github actions file could be modified so that the unit tests have a separate checkmark from the integration tests. The file at: https://github.com/mit-dci/utreexo/blob/master/.github/workflows/go.yml should be modified to achieve this.

samay-kothari commented 2 years ago

Hi @kcalvinalvin, I am new to this project and want to contribute, this seems like a good first issue to me. Can you please elaborate on how you need to distribute the tests. What I can think right now is, we extract the unit test and integration test steps from the build job and run them as different jobs. Will this work? Refer: https://github.com/samay-kothari/utreexo/actions/runs/1903937653

samay-kothari commented 2 years ago

Also fixed the test job for the fuzz.

Refer: https://github.com/samay-kothari/utreexo/actions/runs/1904007542

kcalvinalvin commented 2 years ago

Hey Samay, that looks good but the backwards integration test is failing because it's not finding any github artefacts.

Error: Unable to find any artifacts for the associated workflow

Upload Testdata should be done in the same step as the fetch iirc for it to work correctly.

I think that's the only thing that's missing. Could you make a PR for this and we can review it there.

samay-kothari commented 2 years ago

Hi Calvin, Screenshot 2022-03-04 at 11 38 36 PM As you can see in this attached screenshot, the action of uplaod artifact is saying that there are no files at the provided path. Since, the Unit tests and Integration Tests are seperated and Fuzz testing is fixed, I will make a pull request.