search

mit-han-lab / gan-compression

[CVPR 2020] GAN Compression: Efficient Architectures for Interactive Conditional GANs
Other
1.1k stars 148 forks source link

default setting for opt.phase in evolution_options.py and search_options.py in options directory #78

Closed kminsoo closed 3 years ago

kminsoo commented 3 years ago

Thank you for sharing your code.

Until now, I have read your code only for pix2pix Model Compression part, and I would like to ask you about the part as below. Should the default value for opt.phase be 'train' not 'val' as written in your code for pix2pix model compression in evolution_options.py and search_options.py in options directory? Since you set to the real_stat_path real_stat/edges2shoes-4_subtrain_B.npz, I think that the opt.phase should be set to 'train'.

lmxyy commented 3 years ago

Yes, it should be train. I miss it. Thank you very much for point it out! The detailed reason is specified in #73.