mit-han-lab / torchquantum

A PyTorch-based framework for Quantum Classical Simulation, Quantum Machine Learning, Quantum Neural Networks, Parameterized Quantum Circuits with support for easy deployments on real quantum computers.
https://torchquantum.org
MIT License
1.27k stars 189 forks source link

Amazon Braket backend support #137

Open JordanAWS opened 1 year ago

JordanAWS commented 1 year ago

Adding in an plugin to support Amazon Braket like the qiskit ones here: https://github.com/mit-han-lab/torchquantum/tree/main/torchquantum/plugins

Hanrui-Wang commented 1 year ago

Thank you very much for the help. I have assigned @AbdullahKazi500

JordanAWS commented 1 year ago

Thanks @AbdullahKazi500! Please don't hesitate to reach out if you have questions :)

kvathupo commented 1 year ago

fyi there's a bounty on this issue from Unitary Hack, which asks maintainers to assign an issue after a merged PR (to dole out the bounties per a bot). Despite their privated activity, I suspect @AbdullahKazi500 is asking issues be assigned to them for this reason (github search exists lol):

https://github.com/search?q=AbdullahKazi500&type=issues&p=1

AbdullahKazi500 commented 1 year ago

@kvathupo Hi if you want to work on this issue you are welcome just to let you know I am from a experimental background and I don't code much last year I Did Unitary fund with no bounty I am learning development and trying my hand at open source and people who are completed new to open source should be encouraged if you also want to work on this issue you can go forward and take a try and maybe can close it second thing I am not a bot

AbdullahKazi500 commented 1 year ago

My Activity is private due to my personal projects

kvathupo commented 1 year ago

@AbdullahKazi500 Ah, my sincerest apologies. Bonne chance !

Amana-L commented 1 year ago

Hi @JordanAWS, I would like to work on this. Are you looking to commit the Amazon Braket plugin to the linked repository i.e. torchquantum?

JordanAWS commented 1 year ago

Since multiple people (@AbdullahKazi500 and @Amana-L) have volunteered for this issue, I will ask for the issue to also be assigned to @Amana-L.

Here are the rules: you can either A) Work together on this issue and split the bounty B) Each work independently and race to the finish line. The first person to submit a working PR (including tests) will win the full bounty.

Please let me know what you each prefer by reacting to to this message with an 🅰️ or 🅱️ :)

If a subset of hackers react A, I will take that to mean they are forming a team to work on this issue, and if anyone else reacts B, I will take that to mean that hacker is working independently.

JordanAWS commented 1 year ago

And yes, the idea here is to submit a Braket plugin in the pytorch repo.

JordanAWS commented 1 year ago

@AbdullahKazi500 and @Amana-L -- do you need any support to help complete this issue?

Amana-L commented 1 year ago

Hi @JordanAWS, thanks for checking up.

I'm currently working on it, but I don't know if I can get it done before the UnitaryHack deadline. I'll submit it anyway though :)

Is there a link to the Braket documentation page? I can't seem to find it. Its quite a lot of operations and it would be nice to have all the classes and their methods in one place.

JordanAWS commented 1 year ago

Here you go @Amana-L ! https://amazon-braket-sdk-python.readthedocs.io/en/latest/#

JordanAWS commented 1 year ago

@Amana-L It looks like you weren't quite able to get a PR in for this issue before the June 13th deadline for UnitaryHACK, but if you're still interested in working on this issue, we can offer you AWS credits as an alternative to the bounty :)

Amana-L commented 1 year ago

@JordanAWS Yes, I wasn't able to get through in time. I'm still working on it though and the AWS credits are much appreciated!

nathanshammah commented 1 year ago

@Amana-L if the PRs are accepted in the next few days, the bounties will be awarded.

Hanrui-Wang commented 1 year ago

Dear all,

Thank you for the valuable discussions! I just want to friendly remind that this issue is actually not one of the five issues we posted on the UnitaryHack website. But since this is such an important functionality, I will assign a $50 bounty by myself for a minimum worked version of Braket backend, with more bounty for advanced functions.

JordanAWS commented 1 year ago

@Hanrui-Wang It is one of the bounties posted as part of the Amazon Braket project actually :) https://unitaryhack.dev/projects/amazon-braket-sdk/

@Amana-L If you'd like credits, you'll need to create an AWS account (if you don't have one already), and share your account ID with unitary-hack-braket-support@amazon.com with a request for credits to work on the issue :)