mit-nlp / MITIE

MITIE: library and tools for information extraction
2.92k stars 538 forks source link

Update version of dlib #85

Open stefan-it opened 7 years ago

stefan-it commented 7 years ago

Hi @davisking,

the version of dlib is one year old so I would like to request an update - that would also fix some warnings on newer compilers.

What do you think?

davisking commented 7 years ago

What warnings do you think it would fix?

stefan-it commented 7 years ago

E.g. (using GCC 6.2.1) :

In file included from /mnt/Repositories/mitie/dlib/dlib/data_io/../geometry/../serialize.h:157:0,
                 from /mnt/Repositories/mitie/dlib/dlib/data_io/../geometry/rectangle.h:10,
                 from /mnt/Repositories/mitie/dlib/dlib/data_io/../geometry.h:6,
                 from /mnt/Repositories/mitie/dlib/dlib/data_io/image_dataset_metadata.h:8,
                 from /mnt/Repositories/mitie/dlib/dlib/data_io/image_dataset_metadata.cpp:6:
/mnt/Repositories/mitie/dlib/dlib/data_io/../geometry/../smart_pointers/shared_ptr.h:299:18: warning: 'template<class> class std::auto_ptr' is deprecated [-Wdeprecated-declarations]
             std::auto_ptr<Y>& r

The workaround can be found here.

davisking commented 7 years ago

Ok. Well, I'll update it eventually. However, the new versions of dlib require a C++11 compiler and I don't want to force that on MITIE users yet. As I've learned from the switch to C++11 in dlib proper, there are still lots of people with broken/old compilers out there.

davisking commented 7 years ago

@SakthivelAnand Stop posting comments at random in unrelated github threads.