search

mit-pdos / noria-mysql

MySQL/MariaDB protocol shim for Noria
MIT License
67 stars 15 forks source link

Add listen address argument #13

Closed fussybeaver closed 4 years ago

fussybeaver commented 4 years ago

Removes the --port argument and combines host:port into an --address argument as the listen address.

Fixes #12

jonhoo commented 4 years ago

Looks great to me! @ms705 ?

ms705 commented 4 years ago

Looks good, thanks @fussybeaver! :+1:

ms705 commented 4 years ago

(Travis failures seem unrelated to this PR, but are curious. Did the mysql interfaces change?)

jonhoo commented 4 years ago

@ms705 Oh, yes, it did! It's mostly a matter of different imports due to trait reorganization though.