search

mit-pdos / noria-mysql

MySQL/MariaDB protocol shim for Noria
MIT License
67 stars 15 forks source link

Pin distributary version #2

Closed ekmartin closed 6 years ago

ekmartin commented 6 years ago

When the nom-sql version is upgraded you start getting really weird errors if the distributary version you have cached uses an older nom-sql version (and it won't get upgraded through cargo build - think you have to blow out the cache).

Since we're pinning nom-sql anyway I guess we might as well pin distributary too and avoid the issue altogether?

ms705 commented 6 years ago

Yup, or we could put Cargo.lock under version control.

ekmartin commented 6 years ago

Yep, that sounds reasonable too!

jonhoo commented 6 years ago

FWIW, Cargo.lock should generally be versioned when writing a binary (which is the case here).