search

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.98k stars 242 forks source link

Disable jemalloc on windows to allow windows build #140

Closed DoumanAsh closed 4 years ago

DoumanAsh commented 4 years ago

This is work-around to enable async-await branch to be built on windows.

Proper fix would require fixing jemalloc build script (which is hard for msvc as jemalloc uses autoconf)

ms705 commented 4 years ago

Thanks for this! To confirm: with this change, the async-await branch builds and runs on Windows?

@jonhoo Seems like a worthwhile change to merge, no? Performance without jemalloc could be underwhelming (based on our previous measurements), but making it possible to at least develop on Windows seems reasonable.

DoumanAsh commented 4 years ago

Thanks for this! To confirm: with this change, the async-await branch builds and runs on Windows?

Yes, the only requirement is to add env var LIBCLANG_PATH for bindgen in rocksdb during development

jonhoo commented 4 years ago

Actually, would you mind adding Windows to the testing matrix too? https://github.com/mit-pdos/noria/blob/6c1bfd1e5aab0afee659e03925babbecca44faf9/azure-pipelines.yml#L17-L21

I think:

Windows:
  vmImage: windows-2019

is what you want

DoumanAsh commented 4 years ago

Is azure CI not enabled for PR checks?

jonhoo commented 4 years ago

Huh, apparently not. Should be fixed now if you try to push again.

jonhoo commented 4 years ago

Tests fail, but that's a separate issue. Let's merge.