search

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.99k stars 244 forks source link

Enable local workers in the example #46

Closed ekmartin closed 6 years ago

ekmartin commented 6 years ago

Also adds back logging - not sure if this was removed intentionally, but seems useful to me at least?

ms705 commented 6 years ago

Looks good to me! :+1:

OOI, what happens if set_local_workers() isn't called? The controller presumably waits for remote workers to connect?

ekmartin commented 6 years ago

At the moment it panics, since nworkers is 0. I tried setting nworkers to 2 first, but I realized that nothing starts workers by itself, which means it waits for remote workers like you said.

EDIT: https://github.com/mit-pdos/distributary/blob/master/src/controller/mod.rs#L484

jonhoo commented 6 years ago

That assert should probably be given a description saying that there have to either be local or remote workers.