search

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.99k stars 244 forks source link

Re-enable unused warnings, and fix existing instances of them #47

Closed fintelia closed 6 years ago

fintelia commented 6 years ago

A lot of these changes are in SQL/MIR which I'm not too familiar with, so I didn't want to push to master without confirmation. For the most part I just tagged functions/structs with #[allow(unused)] but it may be the case that many of them should be remove instead.

ms705 commented 6 years ago

Looks good! :+1: I think we should retain all currently unused code in sql and mir -- it either is actually used (as with Recipe), is unused because of a bug (is_leaf argument to nodes_for_named_query), or should be hooked back into higher layers (as with the reuse-related methods on SqlIncorporator).

I'll fix the actual instance of unused code, and the is_leaf bug.

ms705 commented 6 years ago

(OOI, this still seems to fail on Travis due to many unused imports, and due to rustfmt issues. I guess there are more places that need fixing up?)