mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.99k stars 244 forks source link

Implement From<usize> for DataType #49

Closed ekmartin closed 6 years ago

ekmartin commented 6 years ago

Just thought it was annoying having to do (i as i32).into() in tests etc. - feel free to close if there's a good reason why it isn't implemented though!

jonhoo commented 6 years ago

I think the reason was principally because we might want to support unsigned numbers as its own datatype at some point. But it might not be important, since in those cases you would want a usize to be turned into the appropriate type.