search

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.99k stars 244 forks source link

Materialization status in graphviz #51

Closed ekmartin closed 6 years ago

ekmartin commented 6 years ago

The snapshotting implementation needs to know which domains have at least one materialized node, but I thought it might be useful to show it in Blender's graphviz output as well.

I'm not sure if the way I'm retrieving materialization status for a node is correct, so let me know if there's a better way to achieve the same.

This is what it outputs for the example: image

Feel free to bikeshed on how it should be shown in the output - currently it uses a half circle for partial and a full circle for full materializations.

ms705 commented 6 years ago

NICE! I'm a fan :+1:

ms705 commented 6 years ago

LGTM :+1: Let's merge?