search

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow
Apache License 2.0
4.99k stars 244 forks source link

Distinct #80

Closed jsegaran closed 6 years ago

jsegaran commented 6 years ago

This is the distinct operator, but at the moment it requires full materialization to work at the moment, partial isn't yet supported for this operator.

jonhoo commented 6 years ago

Nice! Congratulations on your first Soup operator :D I've left some comments inline, but overall looks pretty good. I'll leave the MIR changes for @ms705 to look at.

ms705 commented 6 years ago

Great work! :+1:

MIR changes look good to me, modulo minor comments.

It'd be good to get this merged, since I plan to rewrite some of the MIR code that this PR modifies. @jsegaran are you likely to have time to finish it off? If not, @jonhoo or myself can take on rebasing, making the changes and merging it.

ms705 commented 6 years ago

Thanks for rebasing! I think this is now good to merge -- @jonhoo?

ms705 commented 6 years ago

Merge -- good work, @jsegaran!