Improve logging consistency throughout the codebase

mit-pdos / noria

Fast web applications through dynamic, partially-stateful dataflow

Apache License 2.0

4.99k stars 244 forks source link

Improve logging consistency throughout the codebase #89

Open jonhoo opened 6 years ago

jonhoo commented 6 years ago

Currently, logging is pretty ad-hoc: different modules use logging levels pretty arbitrarily, and there is important information in trace levels and unimportant info in log. We should take a pass on the code base and figure out what information we usually end up wanting, what information we want for debugging purposes, and what we never even look at.

bartsmykla commented 5 years ago

Hi @jonhoo I would like to start contributing, because I really like the idea behind noria. Can I peek up this issue?

jonhoo commented 5 years ago

Hi @bartsmykla! Sure thing, feel free! I'm having second thoughts about labeling this as "good first issue" though, as figuring out what logging levels are appropriate in each instance, and figuring out what other logging statements will be useful, actually requires a decent familiarity with how the system works internally. If you feel up to the challenge of trying to familiarize yourself with the codebase (and maybe start small?) then go for it! I'd be happy to review PRs!