mit-quest / necstlab-damage-segmentation

MIT License
5 stars 6 forks source link

2dmodels #86

Closed BrendenBarbour closed 3 years ago

BrendenBarbour commented 3 years ago

Adding config file control over the model and backbone from the Segmentation Models Repository. Change the name to Unet, FPN, or Linknet in the config file. Not all backbones work for all models.

rak5216 commented 3 years ago

@BrendenBarbour within each if statement to set model, can u add if's or assert's to verify that a suitable backbone has also been selected (based on your findings in the spreadsheet)? we made this note at the top^

CarolinaFurtado commented 3 years ago

Added my changes:

CarolinaFurtado commented 3 years ago

@BrendenBarbour this looks good!

Did you check that everything is working? As the one pushing the changes, you should be the one to do all the verifications. The reviewers will comment on the code itself and see if structurally it makes sense, but it is important that you do an overall check on what you think might be affected.

A few things that are important to check:

Let me know if you need help!

CarolinaFurtado commented 3 years ago

@BrendenBarbour @rak5216 this looks good!

I'll aprove after you create a template dataset and go through the workflow steps and make sure all are running as we discussed yesterday, @BrendenBarbour

CarolinaFurtado commented 3 years ago

added the possibilities of optimizers and loss functions:

image

any specific loss function you want to add, @rak5216 ?

CarolinaFurtado commented 3 years ago

Overall checks - all working as expected

Checking that all the workflow steps work:

infer - ok

image

dataset generation - ok

image

train- ok

without pretrained model - ok

image

with pretrained model compatible - ok

image

train threshold - ok

image

test - ok

image

infer - ok

image

Pretrained models asserts

with pretrained model NOT COMPATIBLE BACKBONE - ok, assert error

image

with pretrained model NOT COMPATIBLE MODEL - ok, assert error

image

with pretrained model OTHER optimizer- ok, NO ERROR, IT'S UP TO THE USER TO KNOW

image

with pretrained model OTHER loss- ok, NO ERROR, IT'S UP TO THE USER TO KNOW

image

2 model configurations

Unet - ok , verified above

FPN model - ok

image and runs till the end (with batch size of 8)

Linknet model - ok

image and runs till the end