search

mit-racecar / vesc

71 stars 106 forks source link

Assignment instead of equality check? #20

Open joydeep-b opened 5 years ago

joydeep-b commented 5 years ago

There are several lines such as: https://github.com/mit-racecar/vesc/blob/5127d60d8c9cadd2218f49a1b882b3c79710ec3a/vesc_driver/src/vesc_driver.cpp#L155

I believe these should be:

  if (driver_mode_ == MODE_OPERATING) {
dallinbriggs commented 4 years ago

I agree with this.

msadowski commented 4 years ago

I also just came across this issue. If anyone is still maintaining this repo I'm happy to make a PR with a fix