From reading through the source more, and doing some console debugging, this doesn't work the way I thought. Setting this value is an instance variable. So the first time through the LTI process, the call to reload loses this value, and the validation triggered up the call stack in omniauth_callbacks_controller#115 fails. On the second time through, this succeeds because that method isn't called on the user load path.
It's unclear what the user impact here is, since this hasn't come up in any of our manual testing, we haven't had widescale reports of any problems, but the Discourse logging shows this error has affected most users.
Also fix syntax error that wasn't deployed... :| Tested locally.
kevinrobinson
commented
7 years ago
From reading through the source more, and doing some console debugging, this doesn't work the way I thought. Setting this value is an instance variable. So the first time through the LTI process, the call to
reloadloses this value, and the validation triggered up the call stack inomniauth_callbacks_controller#115fails. On the second time through, this succeeds because that method isn't called on the user load path.It's unclear what the user impact here is, since this hasn't come up in any of our manual testing, we haven't had widescale reports of any problems, but the Discourse logging shows this error has affected most users.
Also fix syntax error that wasn't deployed... :| Tested locally.