search

mit-teaching-systems-lab / discourse-edx-lti

Discourse plugin for using Discourse as a discussion forum in EdX courses
http://tsl.mit.edu
MIT License
22 stars 6 forks source link

Cannot access Discourse if user have changed username / email associated to their edx account #32

Open brospars opened 5 years ago

brospars commented 5 years ago

If an user changes his username or email associated with their edx account, then he cannot access Discourse because of this.

Wouldn't it be possible to update his account instead of throwing an error ?

kevinrobinson commented 5 years ago

@brospars Thanks! In my limited experience, this hasn't been an issue, so that's why it's more conservative now. But that may be related to the particular courses, or that they've been smaller and we just haven't run into anyone changing their name yet. :)

If you want to submit a pull request changing this, please include links to EdX documentation and Discourse docs about this, as the plugin would have to make the same assumptions about which is the primary key and how changes are handled (eg, as in https://support.edx.org/hc/en-us/articles/115016004448-Can-I-change-my-edX-username- for EdX).

brospars commented 5 years ago

Yes Edx use the username as primary key, so this plugin could make the same assumption and if the email has changed then update it.

I'm leaving for some days but I will look into it next week

kevinrobinson commented 5 years ago

@brospars Sounds good, pull requests welcome! 👍

I'm also happy to brainstorm on how to verify this is works correctly for the various edge cases, since there's a bunch of risk in deploying that I likely won't be able to verify myself.

brospars commented 3 years ago

@kevinrobinson Hello just to let you know I've opened two PR would you mind taking a look ?