search

mitch-dc / volkswagen_we_connect_id

Apache License 2.0
202 stars 53 forks source link

"Car is active" binary sensor is not corrrect #87

Closed ColinRobbins closed 2 years ago

ColinRobbins commented 2 years ago

Version of the custom_component

0.0.13

Installation method (hacs / manual)

HACS

Installation method of hass (venv, docker, hassio,...)

Venv

Configuration

Default, via config

Describe the bug

The sensor binary_sensor.XXX_car_is_active is always showing true.

Debug log

Using the python library, I've looked at the domain and it shows...

[readiness] Elements: 1 items
    [readinessStatus]
        Connection State: 
            Is online: True
            Battery power level: comfort
            Daily Power Budget Available: True

I.e., The "Is Active" parameter does not appear to be there.

The sensor appears to be returning the previous value. Would it be more appropriate to return None?

pplucky commented 2 years ago

That doesn't happen to me with latest release 0.0.13, but with the latest changes in the repo - check #82

mitch-dc commented 2 years ago

Tested it after latest release and it's fixed :)

ColinRobbins commented 2 years ago

Upgrade to the latest, and it’s still always showing “on” here.

pplucky commented 2 years ago

Upgrade to the latest, and it’s still always showing “on” here.

Same here, already reported via #82 to be reopened.