mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 5 forks source link

[Pull Request] Make MyPlace Extras independent of aircon system #46

Closed uswong closed 2 years ago

uswong commented 2 years ago

name: Pull Request about: Resolve an issue title: "Making MyPlace Extras to be independent of Aircon System" labels: pull-request assignees: mitch7391


Making MyPlace Extras to be independent of Aircon System

Is your pull request related to a problem or a new feature? Please describe: Problem: The temporary cache file required by the MyPlace Extras is created only when the aircon system is running, as such, without the aircon system configured, the Myplace extras will not run smoothly.

Describe the solution you'd have implemented: The solution is to make the required temporary cache file to be created with MyPlace Extras so that even if there is no aircon system configured, it will still be created.

Do your changes pass local testing:

Additional context:

mitch7391 commented 2 years ago

Thank you Ung Sing :)