name: Pull Request
about: Multiple simultaneous zones closing
title: "Improvement to the code for multiple simultaneous zones closing to make it faster"
labels: pull-request
assignees: mitch7391
An improvement to the code to make multiple simultaneous zone closing a bit faster.
Is your pull request related to a problem or a new feature? Please describe:
An improvement
Describe the solution you'd have implemented:
If there are many zone-closing commands done within a very short period of time (<10 seconds), only one queryAirCon() will be called by the first zone-closing command, and the subsequent zone-closing commands will determine the zoneOpen from the zoneOpen.txt cache file instead of making more queryAirCon() calls. The calls to queryAirCon() will most likely fail anyway if they are done within a very short time.
Do your changes pass local testing:
[x] Yes Tested on my E-zone system, passed shellcheck and passed unit tests
name: Pull Request about: Multiple simultaneous zones closing title: "Improvement to the code for multiple simultaneous zones closing to make it faster" labels: pull-request assignees: mitch7391
An improvement to the code to make multiple simultaneous zone closing a bit faster.
Is your pull request related to a problem or a new feature? Please describe: An improvement
Describe the solution you'd have implemented: If there are many zone-closing commands done within a very short period of time (<10 seconds), only one
queryAirCon()will be called by the first zone-closing command, and the subsequent zone-closing commands will determine thezoneOpenfrom thezoneOpen.txtcache file instead of making morequeryAirCon()calls. The calls toqueryAirCon()will most likely fail anyway if they are done within a very short time.Do your changes pass local testing:
Additional context: