mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 5 forks source link

[Pull Request] Bug Fix for `flip` Capability #52

Closed uswong closed 2 years ago

uswong commented 2 years ago

name: Pull Request about: Resolve an issue title: "bug fix for flip capability" labels: pull-request assignees: mitch7391


Fixed a bug on flip capability Is your pull request related to a problem or a new feature? Please describe: A problem reported by @kaim2000 that the flip is not working as intended.

Describe the solution you'd have implemented:

Do your changes pass local testing:

Additional context:

mitch7391 commented 2 years ago

I will do the publish for this tomorrow Ung Sing :)

uswong commented 2 years ago

Whoopsie on the typo haha thanks for the fix though!

haha....thought it was really easy feature to code and did it fairly quickly and did not realize I have a typo. I think shellcheck did not think it is a Boolean, otherwise it could have picked that up.

Anyway, I also need to flip before setting the garage which I did not have in the beta 5 as well.

That is the problem if we do not have a system to test ourself. We should now design a unit tests for it.