search

mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 5 forks source link

[Pull Request] Future Unit Testing via emulated AirCon instead of flat files #53

Closed ztalbot2000 closed 2 years ago

ztalbot2000 commented 2 years ago

name: Pull Request about: Resolve an issue or add an improvement to homebridge-cmd4-AdvantageAir. title: "[Pull Request]" labels: pull-request assignees: mitch7391

Defines PORT as constant for redefinition during Unit test for future AirCon Unit Test Server. Also add to .gitignore the pattern *.[0-9]* of development iteration files **Is your pull request related to a problem or a new feature? Please describe:**

Describe the solution you'd have implemented: The value 2025 is not hard coded everywhere and a constant PORT is created, redefineable in test.

Changing this now helps me rebase your beta branch with mine. **Do your changes pass local testing:** - [x] Yes

Additional context:

uswong commented 2 years ago

Yes, the changes look good to me too.