name: Pull Request
about: Resolve an issue to homebridge-cmd4-AdvantageAir.
title: "Minor bug fixes to AdvAir.sh and AirConServer"
labels: Bug Fix
assignees: mitch7391
A minor bug found with "Timer" accessory and some bugs prevented AirConServer from writing some "Set" commands to the server.
Is your pull request related to a problem or a new feature? Please describe:
Bug fix to AdvAir.sh:
When countDownToOn is set and if the aircon is turned on manually instead, the countDownToOn remains on. It should be turned off because the aircon is now on.
Bug fixes to AirConServer
some "Set" commands do not write to the server. This is due to the double quotes around a number and the path for writing the state of lights and things to the server are not complete.
Describe the solution you'd have implemented:
[x] A new logic was put in so that if the countDownToOn is on and if the aircon is also on, the countDownToOn is turned off.
[x] Removed the double quotes for numbers to ensure successful writing to the server
[x] myThings.things & myLights.lights keys are added to make the path complete to enable the setting of things and lights to the server.
Do your changes pass local testing:
[x] Yes - passed all shellcheck and unit test and tested successfully on my E-zone and JohnW's MyPlace systems
name: Pull Request about: Resolve an issue to homebridge-cmd4-AdvantageAir. title: "Minor bug fixes to AdvAir.sh and AirConServer" labels: Bug Fix assignees: mitch7391
A minor bug found with "Timer" accessory and some bugs prevented AirConServer from writing some "Set" commands to the server.
Is your pull request related to a problem or a new feature? Please describe:
Describe the solution you'd have implemented:
Do your changes pass local testing:
Additional context: