mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 5 forks source link

[Pull Request] Run NPM Audit to Fix Dev Issues #61

Closed mitch7391 closed 2 years ago

mitch7391 commented 2 years ago

Is your pull request related to a problem or a new feature? Please describe:

Issues created by myself in the last commit to v3.4.0-beta.1 to fix 'Prototype Pollution in merge' issue raised by GitHub. Previous commit seemed to inadvertently affect bats and therefore killed all unit tests.

Describe the solution you'd have implemented:

After all the pulling out of my hair, a manual downgrade of bats from v1.7.0 to v1.5.0 , running npm audit and then npm audit fix --force to fix all dependency conflicts; all unit tests seem to be working again.

Do your changes pass local testing:

Additional context: