mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 4 forks source link

[Pull Request] A new script for auto-generation of config.json file and a minor update to aircon timer #65

Closed uswong closed 2 years ago

uswong commented 2 years ago

name: Pull Request about: add an improvement to homebridge-cmd4-AdvantageAir. title: "A new script for auto-generation of config.json file and a minor update to aircon timer " labels: Enhancement assignees: mitch7391


Is your pull request related to a problem or a new feature? Please describe:

  1. The Aircon timer is currently scaled at 1%=10 minutes and users have to think in minutes to set the timer. To set a timer for 1.5 hours, user has to think of a timer for 90 minutes and set the Aircon timer at 9%. Personally, I found it quite a struggle to get it right quickly.

  2. The cmd4-advantageair plugin is by far the most advanced integration of AdvantageAir system with Homekit at the moment but it has a major drawback of needing a massive config.json file. Users found it to be a huge and laborious task to get the config.json file done correctly.

Describe the solution you'd have implemented:

Do your changes pass local testing:

Additional context:

usage of the script cmd4Config_AdvAir.sh:

 This script is to generate a complete cmd4 config.json file needed for the cmd4-advantageair plugin

 - First, identify the IP address of your AdvantageAir (AA) system
 - then on a Terminal on the machine where the homebridge is running
 - run this script as follow:

       ./cmd4Config_AdvAir.sh and you will be asked to input your AA ip address

 or you can pass your AA ip address as an argument:

      ./cmd4Config_AdvAir.sh "your AA ip address"
e.g.  ./cmd4Config_AdvAir.sh "192.168.0.31"

 A config json file in the form of "cmd4Config_AdvAir_xxxxx.json" will be generated.
 xxxxx is the name of your AA system.

 You can copy the content this config json file in its entirety into cmd4 plugin or if you know
 what you are doing you can do some edits, like changing some names or deleting some accessories
 you do not need, etc.

 NOTE:  If you need to 'flip' the GarageDoorOpener, you have to add that in yourself.
mitch7391 commented 2 years ago

I have a few things to get to today Ung Sing, but I have merged this to the master branch and will finish up paperwork and the publish tomorrow.