search

mitch7391 / homebridge-cmd4-AdvantageAir

Catered shell script to integrate air conditioner control units by Advantage Air into HomeKit using the plug-in homebridge-cmd4.
MIT License
38 stars 5 forks source link

[Pull Request] ConfigCreator Bug fix for Mac users #67

Closed uswong closed 1 year ago

uswong commented 1 year ago

changed the command "tac" to "sort -nr". Command "tac" is not available on Mac.

name: Pull Request about: Resolve an issue on ConfigCreator for Mac users title: "Bug fix on ConfigCreator for Mac users" labels: bug fix assignees: mitch7391

The command "tac" is to reverse the sorting order of a file but its not available on Mac machines. As such, the command "sort -nr" is used instead, so that it works for all. Is your pull request related to a problem or a new feature? Please describe:

this pull request is related to a bug for Mac users. Describe the solution you'd have implemented:

Used the command "sort -nr" instead of "tac".

Do your changes pass local testing:

Additional context:

uswong commented 1 year ago

Sorry Mitch for the bug for Mac users.