mitchas / ffftp

Electron FTP manager
184 stars 31 forks source link

Breaking change when running a clean npm install because of angular version #16

Open claudemuller opened 7 years ago

claudemuller commented 7 years ago

I removed the old node_modules (with my pending pull request) and reinstalled them again both on Windows as well as Linux. The app then breaks i.e. the http module has a breaking change (Angular when from 1.5.7 to 1.6.2). In the newer version it is implemented with a promise and requires the use of a .then() instead of .success() and .error(). This causes the app to stop loading when it reaches line 41 in controllers/base.js, which then stops Angular from loading and shows the last element in the DOM tree - the delete confirmation dialog.

I have fixed this in another commit and as soon as the pending pull request gets resolved, I can create another for this fix.

:)