mitchas / ffftp

Electron FTP manager
184 stars 31 forks source link

JavaScript error on menu items #4

Open mitchellknight opened 7 years ago

mitchellknight commented 7 years ago

How to reproduce: Open ffftp.app. Close the window. Select a menu item like Action → Connect or Dev → Dev Tools.

Error Message:

A JavaScript error occurred in the main process Uncaught Exception: Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: undefined at callIntoRenderer (/ffftp.app/Contents/Resources/electron.asar/browser/rpc-server.js:186:19) at MenuItem.click (/ffftp.app/Contents/Resources/electron.asar/browser/api/menu-item.js:82:16) at Function.executeCommand (/ffftp.app/Contents/Resources/electron.asar/browser/api/menu.js:119:40)

Recommendation: If closing the window doesn't close the app (somewhat common on macOS apps), then running any command with the window closed should trigger the window to open before the command is executed.

lukasoppermann commented 7 years ago

Same error here.

screen shot 2017-02-10 at 10 41 08