search

mitchd / stm32flash

Automatically exported from code.google.com/p/stm32flash
0 stars 0 forks source link

code cleanups #50

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I tried building the code with arm-linux-gnueabihf-gcc 4.7.2 with some warnings 
enabled and found some things that look wrong. Attached are 2 patches that fix 
these:
1: C98 (and probably some other versions) don't allow forward-declaring an 
enum. GCC 4.7.2 for ARM gives an error for this, and it's a trivial fix.
2: There were lots of place const was used where it shouldn't be, and a few 
places it needed to be added. It still compiles, so it shouldn't have any 
functional effect, except for possibly the windows code which I didn't try 
compiling.

Original issue reported on code.google.com by bsilver1...@gmail.com on 18 Dec 2013 at 1:50

Attachments:

GoogleCodeExporter commented 9 years ago 
Great, thanks for your contributions! Applied to git.

Original comment by lists.to...@gmail.com on 19 Dec 2013 at 1:32