Several fixes to get code `golint` and `go vet` clean

mitchellh / go-mruby

Go (golang) bindings to mruby.

https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc

MIT License

471 stars 34 forks source link

Several fixes to get code `golint` and `go vet` clean #31

Closed erikh closed 8 years ago

erikh commented 8 years ago

This change is a little bigger but incorporates only one logic change, an unreachable code section found by go vet.

This gets closer to golint happiness too; it only complains about snake case names now. If desirable, I can rewrite the C as well to get golint 100% happy.

erikh commented 8 years ago

one other thing, I moved the ValueType definitions into their own file so they could be omitted from a golint check later. I don't know if it's really a worthwhile exercise to comment them.

mitchellh commented 8 years ago

LGTM!