Apply a warning message recommending vendoring.

mitchellh / go-mruby

Go (golang) bindings to mruby.

https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc

MIT License

471 stars 34 forks source link

Apply a warning message recommending vendoring. #41

Closed erikh closed 8 years ago

erikh commented 8 years ago

@mikesimons pointed out in #18 that vendoring the repo is really the only safe way to rely on the version of libmruby.a in use. I generally agree that this should be vendored and is what I'm doing myself for my own projects.

I have supplied this documentation change to reflect that opinion as a best practice. Let me know what you think.

mitchellh commented 8 years ago

I agree, I'd even go so far as to bold this. But LGTM

mikesimons commented 8 years ago

:+1: to bold but LGTM otherwise

erikh commented 8 years ago

bolded; merging when tests pass