Fix the EC2 block device mappings for image operations

mitchellh / goamz

Golang Amazon Library

Other

672 stars 216 forks source link

Fix the EC2 block device mappings for image operations #252

Closed jsternberg closed 9 years ago

jsternberg commented 9 years ago

Commit 9e419baaaa8185eb20a782ff34003478b683effb introduced a regression that caused any calls for ephemeral disks or no device to include Ebs.DeleteOnTermination, which caused AWS to think we were trying to configure an EBS volume. Since the EBS volume didn't have a VolumeSize or SnapshotId, this predictably failed.

This fixes the branching so when VirtualName or NoDevice are specified it will not attempt to add the EBS related items.

jsternberg commented 9 years ago

Sorry. I was looking at an old version of my personal branch and didn't realize this was already fixed. Closing.