search

mitchellh / libxev

libxev is a cross-platform, high-performance event loop that provides abstractions for non-blocking IO, timers, events, and more and works on Linux (io_uring or epoll), macOS (kqueue), and Wasm + WASI. Available as both a Zig and C API.
MIT License
2.15k stars 77 forks source link

Use of @src() in build system is not functional on Zig master #108

Closed mnemnion closed 3 months ago

mnemnion commented 3 months ago

Caused by this line, which uses @src() here to get the current file path.

@src() no longer includes the full path with .file. There's a .module field, but not yet any way to combine those and get a file handle, this is being tracked as #20999 on the Zig issue board.

mitchellh commented 3 months ago

I need to update the README, but we only pin to released versions now.

mnemnion commented 3 months ago

Suits me. I wanted to create a link trail, because it's unlikely that the change to @src() will be reverted, and the necessary changes for libxev to build on the next release will be showing up at the linked issue.

mnemnion commented 3 months ago

Would this not make sense to keep open as a tracking issue for that change?

mitchellh commented 3 months ago

It's only a bug once Zig is released. Although it's unlikely to be reverted, if we started collecting every Zig master issue and making those judgement calls it'd get annoying really quick. I tend to just wait for a new Zig release, spin up a branch, fix all test failures, and merge that in.

mnemnion commented 3 months ago

Sure. Changing the documentation so it doesn't say Zig nightly would make sense then, but it doesn't need to be tagged as a bug, just a tracking issue for a change which is needed at some future point.

The usual tag for this kind of thing is upstream.