slice mapping bug fix

[ozgursoy]

type Test struct {
    Attributes []byte `json:"attributes"`
}

type TestReq struct {
    Attributes []byte `json:"attributes"`
}

func TestMapping(t *testing.T) {
    req := TestReq{Attributes: []byte(`[{"data": "some data"}]`)}

    var test Test
    test.Attributes = []byte(`[{"a" : "1"}]`)

    err := mapstructure.Decode(req, &test)
    if err != nil {
        panic(err)
    }

    fmt.Println(string(test.Attributes))
    // result will be [{"data": "some data"}]
}

func TestMappingFail(t *testing.T) {
    req := TestReq{Attributes: []byte(`[{"data":"some data"}]`)}

    var test Test
    test.Attributes = []byte(`[{"a":"1111111111111111111111111111111111111111111111"}]`)

    err := mapstructure.Decode(req, &test)
    if err != nil {
        panic(err)
    }

    fmt.Println(string(test.Attributes))
    // result will be [{"data": "some data"}]11111111111111111111111111111111"}]
}

[mitchellh]

Hey this looks really good but I need a failing test case to properly merge this. You almost have that in your PR body but its not quite a test case. Thank you.

[ozgursoy]

Hello @mitchellh,

You are right, I am little lazy person :)

I added a test for that case, I hope this is appropriate. Tested with lastest version of mapstructure that couldn't pass.

Thanks

[mitchellh]

Awesome thank you!