search

mitchellh / panicwrap

panicwrap is a Go library for catching and handling panics in Go applications.
https://gist.github.com/mitchellh/90029601268e59a29e64e55bab1c5bdc
MIT License
443 stars 69 forks source link

Support different panic headers #4

Closed GeertJohan closed 8 years ago

GeertJohan commented 9 years ago

I have added support for multiple panic headers.

The runtime fatal error: fault panic does not start with the text panic:, but it does crash the program. I believe panicwrap should also catch this.

Please note that I have not yet written tests for this change, I can't get the tests to work, for which I have opened a different issue(#3). I wanted to open a PR anyway so you could see what I'm working on and maybe give feedback.

GeertJohan commented 9 years ago

Any thoughts on this?

mitchellh commented 9 years ago

Yeah! This looks really good. I just want to give it a closer look then will merge it in. Thanks :)

GeertJohan commented 9 years ago

Cool! Let me know if you need me to make some changes.

mitchellh commented 8 years ago

LGTM, will add a test as well