Error: Run entered unexpected state "policy_checked", expected applied

[lucymhdavies]

Terraform Version

$ terraform -v
Terraform v1.0.10
on darwin_amd64
+ provider registry.terraform.io/hashicorp/null v3.1.0
+ provider registry.terraform.io/hashicorp/random v3.1.0
+ provider registry.terraform.io/hashicorp/tfe v0.26.1
+ provider registry.terraform.io/hashicorp/time v0.7.2
+ provider registry.terraform.io/mitchellh/multispace v0.1.0

Your version of Terraform is out of date! The latest version
is 1.0.11. You can update by downloading from https://www.terraform.io/downloads.html

Affected Resource(s)

multispace_run

Expected Behavior

What should have happened?

terraform apply should have triggered a run on a workspace, and succeeded once that workspace had completed

Actual Behavior

What actually happened?

╷
│ Error: Run "run-Bd9KyxHaiT5bQgVw" entered unexpected state "policy_checked", expected applied
│
│   with multispace_run.webserver["dev"],
│   on main.tf line 96, in resource "multispace_run" "webserver":
│   96: resource "multispace_run" "webserver" {
│

Steps to Reproduce

• Have some sentinel policies enabled on a workspace
• Workspace should also require manual approval before apply
• Trigger the workspace with multispace_run

Important Factoids

Are there anything atypical about your accounts that we should know? For example: Running in EC2 Classic? Custom version of OpenStack? Tight ACLs?

References

To my layperson's eye, it appears the issue is in (at least) one of these places:

• https://github.com/mitchellh/terraform-provider-multispace/blob/main/internal/provider/resource_run.go#L182-L194
• https://github.com/mitchellh/terraform-provider-multispace/blob/main/internal/provider/resource_run.go#L222-L224
• https://github.com/mitchellh/terraform-provider-multispace/blob/main/internal/provider/resource_run.go#L243-L249

The provider does not account for the possibility that a run may be in a RunPolicy or RunCost state

Seems like a relatively simple fix, so I may see if I can PR it myself :)

[lucymhdavies]

My workaround for now:

• Terraform apply once, get the error
• Workspaces complete their applies
• Terraform apply again, and the provider marks everything as fine

(And same for a Terraform Destroy)

[lucymhdavies]

Looks like my issue is a duplicate of https://github.com/mitchellh/terraform-provider-multispace/issues/3