mitchellh / vagrant-aws

Use Vagrant to manage your EC2 and VPC instances.
MIT License
2.61k stars 574 forks source link

Fix entry about "security_groups" in Readme.md #489

Open bhagerty opened 7 years ago

bhagerty commented 7 years ago

The entry on security groups, as written, does not fully make sense because it contrasts "VPC" and "nondefault VPC." But a "nondefault VPC" is still a "VPC"; in other words, the two categories (VPC and nondefault VPC) actually overlap. The text should refer to a "default VPC" versus a "nondefault VPC"—categories that are mutually exclusive and exhaustive.

While this may seem trivial, it confused me when I was trying to figure out whether to use Group Name or Group ID in my Vagrantfile. I have made some other minor changes that I think make the language even clearer.